| From 39f5d9e883393e32938eac45b564f74afde8a942 Mon Sep 17 00:00:00 2001 |
| From: Rob Herring <robh@kernel.org> |
| Date: Wed, 4 Sep 2019 11:43:30 +0100 |
| Subject: [PATCH] of/address: Translate 'dma-ranges' for parent nodes |
| missing 'dma-ranges' |
| |
| commit 81db12ee15cb83926e290a8a3654a2dfebc80935 upstream. |
| |
| 'dma-ranges' frequently exists without parent nodes having 'dma-ranges'. |
| While this is an error for 'ranges', this is fine because DMA capable |
| devices always have a translatable DMA address. Also, with no |
| 'dma-ranges' at all, the assumption is that DMA addresses are 1:1 with |
| no restrictions unless perhaps the device itself has implicit |
| restrictions. |
| |
| Cc: Robin Murphy <robin.murphy@arm.com> |
| Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> |
| Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> |
| Signed-off-by: Rob Herring <robh@kernel.org> |
| --- |
| drivers/of/address.c | 6 +++++- |
| 1 file changed, 5 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/of/address.c |
| +++ b/drivers/of/address.c |
| @@ -519,9 +519,13 @@ static int of_translate_one(struct devic |
| * |
| * As far as we know, this damage only exists on Apple machines, so |
| * This code is only enabled on powerpc. --gcl |
| + * |
| + * This quirk also applies for 'dma-ranges' which frequently exist in |
| + * child nodes without 'dma-ranges' in the parent nodes. --RobH |
| */ |
| ranges = of_get_property(parent, rprop, &rlen); |
| - if (ranges == NULL && !of_empty_ranges_quirk(parent)) { |
| + if (ranges == NULL && !of_empty_ranges_quirk(parent) && |
| + strcmp(rprop, "dma-ranges")) { |
| pr_debug("no ranges; cannot translate\n"); |
| return 1; |
| } |