| b.liu | e958203 | 2025-04-17 19:18:16 +0800 | [diff] [blame] | 1 | From 4e4637b10374ede3cd33d7e1b389e6cea6343ea3 Mon Sep 17 00:00:00 2001 |
| 2 | From: Colin Ian King <colin.king@canonical.com> |
| 3 | Date: Tue, 12 Nov 2019 13:05:23 +0000 |
| 4 | Subject: [PATCH] net: dsa: mv88e6xxx: fix broken if statement because of a |
| 5 | stray semicolon |
| 6 | |
| 7 | There is a stray semicolon in an if statement that will cause a dev_err |
| 8 | message to be printed unconditionally. Fix this by removing the stray |
| 9 | semicolon. |
| 10 | |
| 11 | Addresses-Coverity: ("Stay semicolon") |
| 12 | Fixes: f0942e00a1ab ("net: dsa: mv88e6xxx: Add support for port mirroring") |
| 13 | Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| 14 | Reviewed-by: Andrew Lunn <andrew@lunn.ch> |
| 15 | Signed-off-by: David S. Miller <davem@davemloft.net> |
| 16 | --- |
| 17 | drivers/net/dsa/mv88e6xxx/chip.c | 2 +- |
| 18 | 1 file changed, 1 insertion(+), 1 deletion(-) |
| 19 | |
| 20 | --- a/drivers/net/dsa/mv88e6xxx/chip.c |
| 21 | +++ b/drivers/net/dsa/mv88e6xxx/chip.c |
| 22 | @@ -4996,7 +4996,7 @@ static void mv88e6xxx_port_mirror_del(st |
| 23 | if (chip->info->ops->set_egress_port(chip, |
| 24 | direction, |
| 25 | dsa_upstream_port(ds, |
| 26 | - port))); |
| 27 | + port))) |
| 28 | dev_err(ds->dev, "failed to set egress port\n"); |
| 29 | } |
| 30 | |