| b.liu | e958203 | 2025-04-17 19:18:16 +0800 | [diff] [blame] | 1 | From ae2259eebeacb7753e3043278957b45840123972 Mon Sep 17 00:00:00 2001 |
| 2 | From: Sieng Piaw Liew <liew.s.piaw@gmail.com> |
| 3 | Date: Wed, 6 Jan 2021 22:42:08 +0800 |
| 4 | Subject: [PATCH 7/7] bcm63xx_enet: improve rx loop |
| 5 | |
| 6 | Use existing rx processed count to track against budget, thereby making |
| 7 | budget decrement operation redundant. |
| 8 | |
| 9 | rx_desc_count can be calculated outside the rx loop, making the loop a |
| 10 | bit smaller. |
| 11 | |
| 12 | Signed-off-by: Sieng Piaw Liew <liew.s.piaw@gmail.com> |
| 13 | Acked-by: Florian Fainelli <f.fainelli@gmail.com> |
| 14 | Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| 15 | --- |
| 16 | drivers/net/ethernet/broadcom/bcm63xx_enet.c | 4 ++-- |
| 17 | 1 file changed, 2 insertions(+), 2 deletions(-) |
| 18 | |
| 19 | --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c |
| 20 | +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c |
| 21 | @@ -340,7 +340,6 @@ static int bcm_enet_receive_queue(struct |
| 22 | priv->rx_curr_desc++; |
| 23 | if (priv->rx_curr_desc == priv->rx_ring_size) |
| 24 | priv->rx_curr_desc = 0; |
| 25 | - priv->rx_desc_count--; |
| 26 | |
| 27 | /* if the packet does not have start of packet _and_ |
| 28 | * end of packet flag set, then just recycle it */ |
| 29 | @@ -405,9 +404,10 @@ static int bcm_enet_receive_queue(struct |
| 30 | dev->stats.rx_bytes += len; |
| 31 | list_add_tail(&skb->list, &rx_list); |
| 32 | |
| 33 | - } while (--budget > 0); |
| 34 | + } while (processed < budget); |
| 35 | |
| 36 | netif_receive_skb_list(&rx_list); |
| 37 | + priv->rx_desc_count -= processed; |
| 38 | |
| 39 | if (processed || !priv->rx_desc_count) { |
| 40 | bcm_enet_refill_rx(dev, true); |