| b.liu | e958203 | 2025-04-17 19:18:16 +0800 | [diff] [blame] | 1 | From be7e1e5b0f67c58ec4be0a54db23b6a4fa6e2116 Mon Sep 17 00:00:00 2001 |
| 2 | From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl> |
| 3 | Date: Fri, 7 Jul 2023 13:40:01 +0200 |
| 4 | Subject: [PATCH] ARM: dts: BCM53573: Drop nonexistent "default-off" LED |
| 5 | trigger |
| 6 | MIME-Version: 1.0 |
| 7 | Content-Type: text/plain; charset=UTF-8 |
| 8 | Content-Transfer-Encoding: 8bit |
| 9 | |
| 10 | There is no such trigger documented or implemented in Linux. It was a |
| 11 | copy & paste mistake. |
| 12 | |
| 13 | This fixes: |
| 14 | arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dtb: leds: led-wlan:linux,default-trigger: 'oneOf' conditional failed, one must be fixed: |
| 15 | 'default-off' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'none', 'torch', 'usb-gadget', 'usb-host', 'usbport'] |
| 16 | 'default-off' does not match '^cpu[0-9]*$' |
| 17 | 'default-off' does not match '^hci[0-9]+-power$' |
| 18 | 'default-off' does not match '^mmc[0-9]+$' |
| 19 | 'default-off' does not match '^phy[0-9]+tx$' |
| 20 | From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml |
| 21 | |
| 22 | Signed-off-by: Rafał Miłecki <rafal@milecki.pl> |
| 23 | Link: https://lore.kernel.org/r/20230707114004.2740-1-zajec5@gmail.com |
| 24 | Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> |
| 25 | --- |
| 26 | arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts | 1 - |
| 27 | arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts | 2 -- |
| 28 | 2 files changed, 3 deletions(-) |
| 29 | |
| 30 | --- a/arch/arm/boot/dts/bcm47189-luxul-xap-1440.dts |
| 31 | +++ b/arch/arm/boot/dts/bcm47189-luxul-xap-1440.dts |
| 32 | @@ -26,7 +26,6 @@ |
| 33 | led-wlan { |
| 34 | label = "bcm53xx:blue:wlan"; |
| 35 | gpios = <&chipcommon 10 GPIO_ACTIVE_LOW>; |
| 36 | - linux,default-trigger = "default-off"; |
| 37 | }; |
| 38 | |
| 39 | led-system { |
| 40 | --- a/arch/arm/boot/dts/bcm47189-luxul-xap-810.dts |
| 41 | +++ b/arch/arm/boot/dts/bcm47189-luxul-xap-810.dts |
| 42 | @@ -26,7 +26,6 @@ |
| 43 | led-5ghz { |
| 44 | label = "bcm53xx:blue:5ghz"; |
| 45 | gpios = <&chipcommon 11 GPIO_ACTIVE_HIGH>; |
| 46 | - linux,default-trigger = "default-off"; |
| 47 | }; |
| 48 | |
| 49 | led-system { |
| 50 | @@ -42,7 +41,6 @@ |
| 51 | led-2ghz { |
| 52 | label = "bcm53xx:blue:2ghz"; |
| 53 | gpios = <&pcie0_chipcommon 3 GPIO_ACTIVE_HIGH>; |
| 54 | - linux,default-trigger = "default-off"; |
| 55 | }; |
| 56 | }; |
| 57 | |