| b.liu | e958203 | 2025-04-17 19:18:16 +0800 | [diff] [blame^] | 1 | From 339666068713986cfe1456175dd8a7514f6ed2ab Mon Sep 17 00:00:00 2001 |
| 2 | From: Hans de Goede <hdegoede@redhat.com> |
| 3 | Date: Mon, 18 Nov 2019 16:51:31 +0100 |
| 4 | Subject: [PATCH] drm/modes: parse_cmdline: Remove some unnecessary |
| 5 | code (v2) |
| 6 | |
| 7 | Commit 5b926617cdef41ce0696e09834991194b1759e28 upstream. |
| 8 | |
| 9 | fb_get_options() will return fb_mode_option if no video=<connector-name> |
| 10 | argument is present on the kernel commandline, so there is no need to also |
| 11 | do this in drm_mode_parse_command_line_for_connector() as our only caller |
| 12 | uses fb_get_options() to get the mode_option argument. |
| 13 | |
| 14 | Changes in v2: |
| 15 | -Split out the changes dealing with the initialization of the mode struct |
| 16 | into a separate patch |
| 17 | |
| 18 | Acked-by: Maxime Ripard <mripard@kernel.org> |
| 19 | Signed-off-by: Hans de Goede <hdegoede@redhat.com> |
| 20 | Link: https://patchwork.freedesktop.org/patch/msgid/20191118155134.30468-10-hdegoede@redhat.com |
| 21 | --- |
| 22 | drivers/gpu/drm/drm_modes.c | 5 ----- |
| 23 | 1 file changed, 5 deletions(-) |
| 24 | |
| 25 | --- a/drivers/gpu/drm/drm_modes.c |
| 26 | +++ b/drivers/gpu/drm/drm_modes.c |
| 27 | @@ -1754,11 +1754,6 @@ bool drm_mode_parse_command_line_for_con |
| 28 | |
| 29 | mode->panel_orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN; |
| 30 | |
| 31 | -#ifdef CONFIG_FB |
| 32 | - if (!mode_option) |
| 33 | - mode_option = fb_mode_option; |
| 34 | -#endif |
| 35 | - |
| 36 | if (!mode_option) { |
| 37 | mode->specified = false; |
| 38 | return false; |