| b.liu | e958203 | 2025-04-17 19:18:16 +0800 | [diff] [blame^] | 1 | From: Russell King <rmk+kernel@armlinux.org.uk> |
| 2 | Bcc: linux@mail.armlinux.org.uk |
| 3 | Subject: [PATCH 4/7] i2c: pxa: remove some unnecessary debug |
| 4 | MIME-Version: 1.0 |
| 5 | Content-Disposition: inline |
| 6 | Content-Transfer-Encoding: 8bit |
| 7 | Content-Type: text/plain; charset="utf-8" |
| 8 | |
| 9 | Remove unnecessary show_state() in the loop inside |
| 10 | i2c_pxa_pio_set_master(), which can be unnecessarily verbose. |
| 11 | |
| 12 | Remove the i2c_pxa_scream_blue_murder() in i2c_pxa_pio_xfer(), which |
| 13 | will trigger if we are probing the I2C bus and a slave does not |
| 14 | respond; this is a normal event, and not something to report. |
| 15 | |
| 16 | Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> |
| 17 | --- |
| 18 | drivers/i2c/busses/i2c-pxa.c | 4 +--- |
| 19 | 1 file changed, 1 insertion(+), 3 deletions(-) |
| 20 | |
| 21 | --- a/drivers/i2c/busses/i2c-pxa.c |
| 22 | +++ b/drivers/i2c/busses/i2c-pxa.c |
| 23 | @@ -1114,10 +1114,8 @@ static int i2c_pxa_pio_set_master(struct |
| 24 | /* |
| 25 | * Wait for the bus to become free. |
| 26 | */ |
| 27 | - while (timeout-- && readl(_ISR(i2c)) & (ISR_IBB | ISR_UB)) { |
| 28 | + while (timeout-- && readl(_ISR(i2c)) & (ISR_IBB | ISR_UB)) |
| 29 | udelay(1000); |
| 30 | - show_state(i2c); |
| 31 | - } |
| 32 | |
| 33 | if (timeout < 0) { |
| 34 | show_state(i2c); |