| b.liu | e958203 | 2025-04-17 19:18:16 +0800 | [diff] [blame^] | 1 | From ac2fb1a9879204825467eed7a138a3d77c1ecfe8 Mon Sep 17 00:00:00 2001 |
| 2 | From: Arnd Bergmann <arnd@arndb.de> |
| 3 | Date: Mon, 16 Dec 2019 00:12:14 +0200 |
| 4 | Subject: [PATCH] net: dsa: ocelot: add NET_VENDOR_MICROSEMI dependency |
| 5 | |
| 6 | Selecting MSCC_OCELOT_SWITCH is not possible when NET_VENDOR_MICROSEMI |
| 7 | is disabled: |
| 8 | |
| 9 | WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH |
| 10 | Depends on [n]: NETDEVICES [=y] && ETHERNET [=n] && NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y] |
| 11 | Selected by [m]: |
| 12 | - NET_DSA_MSCC_FELIX [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && NET_DSA [=y] && PCI [=y] |
| 13 | |
| 14 | Add a Kconfig dependency on NET_VENDOR_MICROSEMI, which also implies |
| 15 | CONFIG_NETDEVICES. |
| 16 | |
| 17 | Depending on a vendor config violates menuconfig locality for the DSA |
| 18 | driver, but is the smallest compromise since all other solutions are |
| 19 | much more complicated (see [0]). |
| 20 | |
| 21 | https://www.spinics.net/lists/netdev/msg618808.html |
| 22 | |
| 23 | Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family") |
| 24 | Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| 25 | Signed-off-by: Mao Wenan <maowenan@huawei.com> |
| 26 | Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> |
| 27 | Signed-off-by: David S. Miller <davem@davemloft.net> |
| 28 | --- |
| 29 | drivers/net/dsa/ocelot/Kconfig | 1 + |
| 30 | 1 file changed, 1 insertion(+) |
| 31 | |
| 32 | --- a/drivers/net/dsa/ocelot/Kconfig |
| 33 | +++ b/drivers/net/dsa/ocelot/Kconfig |
| 34 | @@ -2,6 +2,7 @@ |
| 35 | config NET_DSA_MSCC_FELIX |
| 36 | tristate "Ocelot / Felix Ethernet switch support" |
| 37 | depends on NET_DSA && PCI |
| 38 | + depends on NET_VENDOR_MICROSEMI |
| 39 | select MSCC_OCELOT_SWITCH |
| 40 | select NET_DSA_TAG_OCELOT |
| 41 | help |